fix(eth): present revert "data" as plain bytes #12675
Merged
+42
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
#12553 has details of my investigation into this, I'll also be following up with PRs to fevm-uniswap-tests and fevm-contract-tests to match this. |
decode the cbor return value for reverts and present that, as is expected by Ethereum tooling
rvagg
force-pushed
the
rvagg/revert-data
branch
from
5b604da to
57fe40e
Compare
aarshkshah1992
approved these changes
Nov 7, 2024
8 tasks
rvagg
added a commit
to filecoin-project/fevm-uniswap-v3-core
that referenced
this pull request
Nov 7, 2024
rvagg
added a commit
to filecoin-project/fevm-uniswap-v3-core
that referenced
this pull request
Nov 7, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode the cbor return value for reverts and present that, as is expected by Ethereum tooling